Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (build): Use @io_grpc_grpc_java from grpc.io instead rules-proto-grpc.com #205

Merged
merged 1 commit into from
Dec 31, 2023
Merged

fix (build): Use @io_grpc_grpc_java from grpc.io instead rules-proto-grpc.com #205

merged 1 commit into from
Dec 31, 2023

Conversation

vorburger
Copy link
Member

Follow-up to #204 to fully fix #202

Re. grpc/grpc-java#10215

@vorburger
Copy link
Member Author

I should split this PR up into 2 parts:

A. switching from @io_grpc_grpc_java//api + @io_grpc_grpc_java//stub to @maven//:io_grpc_grpc_api and "@maven//:io_grpc_grpc_stub (this part already works and could be merged ASAP)

B. switching from load("@rules_proto_grpc//java:repositories.bzl", rules_proto_grpc_java_repos = "java_repos") to http_archive(name = "io_grpc_grpc_java" etc. (this is still a mess and requires more work)

@vorburger vorburger mentioned this pull request May 31, 2023
Merged
@vorburger
Copy link
Member Author

A. is done in #218

@vorburger vorburger mentioned this pull request Jun 23, 2023
Closed
@vorburger vorburger force-pushed the issue-202_java_proto_library_II branch from a5a59db to 93bf35a Compare June 23, 2023 14:12
@vorburger vorburger force-pushed the issue-202_java_proto_library_II branch from 93bf35a to 04360c9 Compare December 31, 2023 02:33
@vorburger vorburger force-pushed the issue-202_java_proto_library_II branch from 04360c9 to ce4c245 Compare December 31, 2023 02:50
@vorburger vorburger marked this pull request as ready for review December 31, 2023 02:56
@vorburger vorburger merged commit 38ba2ef into enola-dev:main Dec 31, 2023
@vorburger vorburger deleted the issue-202_java_proto_library_II branch December 31, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Protocol Buffer and gRPC from rules_proto_grpc to grpc/grpc-java
1 participant
@vorburger