Comment Section Fix #966
Comment Section Fix #966
Conversation
|
@hanakoori01 I like this solution, looks great. Have you tried deploying the smart contract (without any modification), do some comments, and then compile and deploy these changes you are proposing to validate the backend and smart contract behave as expecting? |
|
Yes of course @leisterfrancisco I did those tests before uploading the changes to GitHub, to validate that it was working correctly! |
|
This pull request introduces 1 alert when merging 8f9f8bc into db31101 - view on LGTM.com new alerts:
|
| } = action | ||
| if (!isEden) return |
There was a problem hiding this comment.
Clean code
blank line before and after of if conditional
| } = action | ||
| let userRatings | ||
| if (isEden === null) return |
There was a problem hiding this comment.
Still pending blank line before of if
There was a problem hiding this comment.
It is already fixed!
| @@ -44,7 +44,7 @@ using eosio::public_key; | |||
| */ | |||
| namespace eosio { | |||
| constexpr name system_account{"eosio"_n}; | |||
| constexpr name eden_account{"genesis.eden"_n}; | |||
| constexpr name eden_account{"genesisdeden"_n}; | |||
There was a problem hiding this comment.
use genesis.eden instead of genesisdeden
There was a problem hiding this comment.
I am a bit confused, aren't we supposed to use genesisdeden because we are using jungle 4 account?
There was a problem hiding this comment.
mainnet: genesis.eden
tesnet: genesisdeden
we are trying to get the genesis.eden account name on testnet but not yet
PR - EOS RATE
What does this PR do?
Steps to test
make runlocalhost:3000