Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net_plugin transaction dedup cache handling #56

Merged
merged 3 commits into from
Mar 16, 2022
Merged

net_plugin transaction dedup cache handling #56

merged 3 commits into from
Mar 16, 2022

Conversation

heifner
Copy link
Member

@heifner heifner commented Mar 13, 2022

  • Add option p2p-dedup-cache-expire-time-sec for configurating the transaction deduplication cache expiration time.
  • Simplify transaction deduplication cache handling to just be a configurable expire time.
    • The dedup cache, local_txns, is simply an optimization in net_plugin to avoid tripping duplication transaction exception in controller.
    • The current implementation (before this PR) prevents clients from re-trying transactions as the net_plugin would not accept the transaction again until it expired or it appeared in a block.

@heifner heifner changed the title WIP: net_plugin transaction dedup cache handling net_plugin transaction dedup cache handling Mar 13, 2022
brianjohnson5972
brianjohnson5972 suggested changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@brianjohnson5972 brianjohnson5972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor changes

@heifner
Copy link
Member Author

heifner commented Mar 15, 2022

2 minor changes

I only see one requested change.

@brianjohnson5972 brianjohnson5972 merged commit 9402751 into feature/oci_api_phase1 Mar 16, 2022
@heifner heifner deleted the net-plugin-config-expire-trx branch March 19, 2022 12:43
@spoonincode spoonincode mentioned this pull request May 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjohnson5972 brianjohnson5972 brianjohnson5972 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heifner @brianjohnson5972