New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Finality Status storage #81

Merged

brianjohnson5972 merged 19 commits into feature/oci_api_phase1 from enfs-15_bdj_status_storage

Apr 14, 2022

Contributor

brianjohnson5972 commented Apr 5, 2022

Added storage for FInality Status feature and using signals_processor to populate.

brianjohnson5972 added 3 commits

March 31, 2022 08:47


          Adding storage for finality status.

a648d4a


          Moved trx_finality_status_processing functionality into an impl.

176424f


          Added duration configuration and access to state.

98f5316

brianjohnson5972 requested a review from heifner

April 5, 2022 18:06

brianjohnson5972 changed the base branch from main to feature/oci_api_phase1

April 5, 2022 18:08

brianjohnson5972 marked this pull request as draft

April 5, 2022 18:08

heifner suggested changes

View reviewed changes

libraries/chain/include/eosio/chain/config.hpp Outdated Show resolved Hide resolved

plugins/chain_plugin/chain_plugin.cpp Outdated Show resolved Hide resolved

plugins/chain_plugin/chain_plugin.cpp Outdated Show resolved Hide resolved

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

plugins/chain_plugin/trx_finality_status_processing.cpp Show resolved Hide resolved

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

brianjohnson5972 added 2 commits

April 6, 2022 19:44


          Fixed ensure_storage and added block id.

ead15c5


          Fixed peer review comments.

1f9f3e2

brianjohnson5972 marked this pull request as ready for review

April 7, 2022 05:05

brianjohnson5972 changed the title ~~WIP: Adding Finality Status storage~~ Adding Finality Status storage

brianjohnson5972 requested a review from heifner

April 7, 2022 05:05

brianjohnson5972 added 3 commits

April 7, 2022 05:07


          Merge remote-tracking branch 'origin/feature/oci_api_phase1' into enf…

4023e1d

…s-15_bdj_status_storage


          Changed stored type's size method to be memory_size

e64d9ce


          Changed to not drop useful block info when transaction is forked_out.

5f15366

heifner reviewed

View reviewed changes

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

brianjohnson5972 added 2 commits

April 7, 2022 06:35


          Made status all one word.

e7bc0f9


          Fixed compile error.

716dc79

heifner reviewed

View reviewed changes

plugins/chain_plugin/include/eosio/chain_plugin/finality_status_object.hpp Outdated Show resolved Hide resolved

heifner reviewed

View reviewed changes

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

heifner reviewed

View reviewed changes

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

heifner reviewed

View reviewed changes

plugins/chain_plugin/include/eosio/chain_plugin/finality_status_object.hpp Outdated Show resolved Hide resolved

heifner reviewed

View reviewed changes

plugins/chain_plugin/include/eosio/chain_plugin/finality_status_object.hpp Outdated Show resolved Hide resolved

heifner reviewed

View reviewed changes

plugins/chain_plugin/trx_finality_status_processing.cpp Show resolved Hide resolved

heifner reviewed

View reviewed changes

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

heifner reviewed

View reviewed changes

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

brianjohnson5972 requested a review from heifner

April 7, 2022 16:30

heifner reviewed

View reviewed changes

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

heifner reviewed

View reviewed changes

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

heifner reviewed

View reviewed changes

plugins/chain_plugin/trx_finality_status_processing.cpp Outdated Show resolved Hide resolved

brianjohnson5972 added 3 commits

April 7, 2022 11:18


          Dropping comparitor and adding block_num method.

2e718d0


          Use project to avoid performing a lookup in the primary index for rem…

e5216c6

…oving entries.


          Cleaned up unused param.

011990b

brianjohnson5972 requested a review from heifner

April 7, 2022 20:33

brianjohnson5972 added 5 commits

April 13, 2022 17:26


          Fixed logic based on unit testing.

140ddbe


          Reporting memory size to improve testing.

3adedef


          Added unit tests for Finality Status.

5e91fd7


          Fixed error.

fc370f7


          Added to test and fixed more exposed errors.

27d578b

heifner approved these changes

View reviewed changes


          Merge remote-tracking branch 'origin/feature/oci_api_phase1' into enf…

0f6faf3

…s-15_bdj_status_storage

brianjohnson5972 merged commit 7dd54b3 into feature/oci_api_phase1

brianjohnson5972 deleted the enfs-15_bdj_status_storage branch

April 14, 2022 20:34

heifner mentioned this pull request

API+ features for Mandel 3.1 #61

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet