Incorrect display of utf8 text in standalone #889 #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,7 @@ option(WITH_STATIC "Build Indigo static library as well as shared" OFF) | |||
|
|
|||
| # Indigo API options | |||
| option(BUILD_INDIGO "Build indigo shared library" ON) | |||
| option(USE_FONT_MANAGER "Build indigo render with font_face_manager" OFF) | |||
There was a problem hiding this comment.
We already have BUILD_STANDALONE for that. I would suggest to use font manager in case of standalone build.
There was a problem hiding this comment.
Right now, we want to use font manager only in case of WASM.
It will be added later to standalone.
| else() | ||
| add_subdirectory(cairo) | ||
| if (UNIX AND NOT APPLE) | ||
| add_subdirectory(freetype) |
There was a problem hiding this comment.
We also need to add possibility to use system freetype on Linux (see cairo or libpng or libz as an example).
There was a problem hiding this comment.
Fixed.
In case of NOT EMSCRIPTEN system freetype and fontconfig libs will be used.
There was a problem hiding this comment.
No, it's not only about NOT EMSCRIPTEN, it's also about BUILD_STANDALONE.
IvanMinin
changed the title
mkviatkovskii
approved these changes
Jan 11, 2023
mkviatkovskii
deleted the
bugfix/889-incorrect-display-of-utf8-text-in-standalone
branch
loimu
pushed a commit
that referenced
this pull request
Jan 17, 2023
* added own-built freetype; removed cairo-wasm * returned freetype CMakeLists.txt to the original state * fixed freetype building * added sans fonts files * added rendere_font_face_manager; support of external fonts * added utf8 tests to indigo-ketcher * clang-format fix for sans fonts files * clang-format fix for font_face_manager files * fixed build for non UNIX builds * clang_format fix * fixed freetype build * selected FreeType License (FTL) as used license * selected FreeType License (FTL) as used license * moved sans fonts files; added OFL license file * fixed build and CMakeFiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.