Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peptide sequence not pasting directly on canvas #6588

Open
Tracked by #6602
Zhirnoff opened this issue Mar 3, 2025 · 1 comment · May be fixed by #6610
Open
Tracked by #6602

Peptide sequence not pasting directly on canvas #6588

Zhirnoff opened this issue Mar 3, 2025 · 1 comment · May be fixed by #6610
Assignees
Labels
Priority: High Sequence mode Bucket: Sequence mode related issues Severity: High High level visibility to the user User`s Feedback

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Mar 3, 2025

This is FRONTEND PART
Backend part: epam/Indigo#2798

Description:
A peptide sequence cannot be pasted directly onto the canvas, while using the "Paste from Clipboard" option works correctly. The error message indicates that sequence contains an unknown polymer type.

Steps to Reproduce

  1. Open Sequence mode
  2. Copy and paste directly onto the canvas sequence GATYLIK

Actual behavior
An error message appears:

Image

The input_format is missing in the Payload

Image

However, when using "Paste from Clipboard", the sequence is inserted correctly and input_format is presenting in the Payload

Image

Expected behavior
The peptide sequence GATYLIK should be placed on the canvas correctly without errors.

Recognition order should be (as per #5974):

  1. Sequence 3-letter (according Macro: Paste from clipboard in sequence mode #3894 - we should use type defined by the "Type" control in toolbar)
  2. IDT
  3. Sequence 1-letter (according Macro: Paste from clipboard in sequence mode #3894 - we should use type defined by the "Type" control in toolbar, if Peptide selected - skip step 4)
  4. Sequence 1-letter (type Peptide)
  5. ... all the rest

Notes for dev

  • remove autodetection logic for sequence/idt/fasta from Ketcher
  • do not send input-format to backend
  • send sequence-type parameter to backend with value according to selected sequence type in sequence mode on top toolbar
  • import new indigo version with fix of Peptide sequence not pasting directly on canvas Indigo#2798

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 133.0.6943.127 (Official Build) (64-bit)

Ketcher version
[Version 3.1.0-rc.6]
Indigo version
[Version 1.29.0-rc.1]

@Zhirnoff Zhirnoff added Priority: High Sequence mode Bucket: Sequence mode related issues Severity: High High level visibility to the user User`s Feedback labels Mar 3, 2025
@rrodionov91 rrodionov91 self-assigned this Mar 4, 2025
@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Mar 5, 2025

Duplicates #5974

That should be solved on Indigo side

Recognition order should be:

  1. Sequence 3-letter (according Macro: Paste from clipboard in sequence mode #3894 - we should use type defined by the "Type" control in toolbar)
  2. IDT
  3. Sequence 1-letter (according Macro: Paste from clipboard in sequence mode #3894 - we should use type defined by the "Type" control in toolbar, if Peptide selected - skip step 4)
  4. Sequence 1-letter (type Peptide)
  5. ... all the rest

@AlexeyGirin AlexeyGirin marked this as a duplicate of #5974 Mar 5, 2025
rrodionov91 added a commit that referenced this issue Mar 5, 2025
- removed format autodetection during copy/paste from ketcher
- added sequence-type parameter to indigo convert payload
@rrodionov91 rrodionov91 linked a pull request Mar 5, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Sequence mode Bucket: Sequence mode related issues Severity: High High level visibility to the user User`s Feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants