This repository was archived by the owner on Nov 18, 2024. It is now read-only.
Add ENS name and image view to conversations #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
approved these changes
Jan 17, 2023
| self.ensName = value | ||
| } | ||
| case let .couldNotBeResolved(error): | ||
| print("Could not resolve ENS name: \(error)") |
There was a problem hiding this comment.
Maybe if it can't be resolved we just fall back to the wallet address?
There was a problem hiding this comment.
Yes! I fallback in the body method right now
| case let .resolved(value): | ||
| await loadEnsImage(ensName: value) | ||
| case let .couldNotBeResolved(error): | ||
| print("Could not resolve ENS name: \(error)") |
There was a problem hiding this comment.
Same as the name can we roll back to a default image?
There was a problem hiding this comment.
Same page -- I actually fallback to an IGIdenticon in the EnsImageView 💚 https://github.com/xmtp-labs/xmtp-inbox-ios/pull/24/files#diff-08ce830c1dc75176d0522b3d4f226524fbb8eaa74a662efa577299c988620465R42
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to query Infura for ENS information and display it for each conversation in the list. I added a README with steps to configure Infura instead of committing an Infura url directly. Also in order to accomplish this, it adds three new libraries:
Relates to #18