feat(rpc/v05): add starknet_getTransactionReceipt implementation
#1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre-l
force-pushed
the
1429-get-transaction-receipt
branch
from
e343b61 to
4644539
Compare
There was a problem hiding this comment.
ito tests I would add one just to verify the From impl for resources because that is brand new here. So just something that ensures that each field is mapped correctly by using different numbers for each field. Currently the only test exercising this is the json output which is defaulted i.e. all 0 so you won't pick up anything bad.
ito code reuse - I think in the spirit of getting this out we can just copy paste for now to be safer. i.e. to be sure we don't change v0.4 behaviour. We should tackled code reuse in the future though; but we aren't really ready for that yet imo.
pierre-l
force-pushed
the
1429-get-transaction-receipt
branch
from
a269922 to
8ad3801
Compare
Mirko-von-Leipzig
approved these changes
Oct 20, 2023
Duplicate the v04 implementation before making changes
Move the pending receipt struct next to the regular receipt struct
Add the "execution_resources" field Introduce a new `ExecutionResourcesProperties` to filter out the unnecessary fields from `ExecutionResources`
pierre-l
force-pushed
the
1429-get-transaction-receipt
branch
from
8ad3801 to
762dffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation for
starknet_getTransactionReceipt.The only change I have found in the spec is, as mentioned in the original issue, the addition of the
execution_resourcesresources field.The first commit consists in copy-pasting the v0.4 implementation, so I recommend reviewing this PR commit by commit.
Please let me know all that I can improve, including:
Closes #1429