Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup asof join warnings #10199

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Mar 4, 2025

Issue
Resolves #10189

Sorts only by the on column, ref https://docs.pola.rs/api/python/stable/reference/dataframe/api/polars.DataFrame.join_asof.html

Both DataFrames must be sorted by the on key (within each by group, if specified).

Sorting "flat" only by on seems to not give the warning

@yngve-sk yngve-sk force-pushed the 25.03.04.fixup-asofjoin-everestrunmodel branch from ccc77d0 to e5e1327 Compare March 4, 2025 08:43
@yngve-sk yngve-sk force-pushed the 25.03.04.fixup-asofjoin-everestrunmodel branch from e5e1327 to dcc2ac2 Compare March 4, 2025 08:50
Copy link

codspeed-hq bot commented Mar 4, 2025

CodSpeed Performance Report

Merging #10199 will not alter performance

Comparing yngve-sk:25.03.04.fixup-asofjoin-everestrunmodel (dcc2ac2) with main (361d9f8)

Summary

✅ 25 untouched benchmarks

@yngve-sk yngve-sk marked this pull request as ready for review March 4, 2025 09:16
@yngve-sk yngve-sk marked this pull request as draft March 4, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solve UserWarning: left key of asof join is not sorted
1 participant