Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for invalid transform functions #10232

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

larsevj
Copy link
Collaborator

@larsevj larsevj commented Mar 6, 2025

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj force-pushed the fix_validation_lognormal branch from 8bb1fb9 to f02ad9d Compare March 6, 2025 16:25
Copy link

codspeed-hq bot commented Mar 6, 2025

CodSpeed Performance Report

Merging #10232 will not alter performance

Comparing larsevj:fix_validation_lognormal (f02ad9d) with main (1c925c8)

Summary

✅ 25 untouched benchmarks

eivindjahren
eivindjahren previously approved these changes Mar 7, 2025
@eivindjahren eivindjahren changed the title Improve validation in parse_transform_function_definition Improve validation of transform functions Mar 7, 2025
@eivindjahren eivindjahren added the release-notes:improvement Automatically categorise as improvement in release notes label Mar 7, 2025
@eivindjahren eivindjahren changed the title Improve validation of transform functions Improve error messages for invalid transform functions Mar 7, 2025
@eivindjahren eivindjahren dismissed their stale review March 7, 2025 09:17

After looking at this closer, it seems to not be ready.

@larsevj larsevj self-assigned this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants