Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save batch data to file after batch evaluation #10243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yngve-sk
Copy link
Contributor

Issue
Resolves #10235

Approach
Write results after each batch evaluation, then do a final overwrite at the end. Final overwrite would not have to happen if it weren't for parsing of the dakota merit values.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Mar 10, 2025

CodSpeed Performance Report

Merging #10243 will not alter performance

Comparing yngve-sk:25.03.07.save-batchdata-instantly (a8584a5) with main (657656b)

Summary

✅ 25 untouched benchmarks

@yngve-sk yngve-sk marked this pull request as ready for review March 10, 2025 07:30
@frode-aarstad
Copy link
Contributor

Is it possible to add a regression test for this?

@yngve-sk yngve-sk force-pushed the 25.03.07.save-batchdata-instantly branch from 054d850 to a8584a5 Compare March 10, 2025 12:21
@yngve-sk
Copy link
Contributor Author

Is it possible to add a regression test for this?

Added a regression test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Everest does not dump results until run is complete
2 participants