Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning from polars #10300

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

larsevj
Copy link
Collaborator

@larsevj larsevj commented Mar 13, 2025

Fixes the warning everest_storage.py:507: DeprecationWarning: The argument columnsforDataFrame.pivotis deprecated. It has been renamed toon``

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj requested a review from yngve-sk March 13, 2025 11:37
@larsevj larsevj self-assigned this Mar 13, 2025
@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Mar 13, 2025
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛳️

@larsevj larsevj enabled auto-merge (rebase) March 13, 2025 11:55
@larsevj larsevj merged commit 6d86949 into equinor:main Mar 13, 2025
26 checks passed
@larsevj larsevj deleted the fix_deprecation_warning_polars branch March 13, 2025 11:55
Copy link

codspeed-hq bot commented Mar 13, 2025

CodSpeed Performance Report

Merging #10300 will not alter performance

Comparing larsevj:fix_deprecation_warning_polars (15f9ed9) with main (ec0a372)

Summary

✅ 25 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants