Enforce minimum npm and node version
#971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders-kiaer
force-pushed
the
enforcenodeversion
branch
2 times, most recently
from
9888baf to
bdb7b8f
Compare
|
Thanks @anders-kiaer this was much needed |
|
It breaks storybook, defining host in storybook script works ("storybook": "start-storybook -p 6006 -h localhost") |
hkfb
approved these changes
May 6, 2022
Works with node version 16 |
hkfb
requested changes
May 6, 2022
anders-kiaer
force-pushed
the
enforcenodeversion
branch
from
bdb7b8f to
90c33db
Compare
|
Perhaps I should also remove |
hkfb
approved these changes
May 6, 2022
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
=======================================
Coverage 44.98% 44.98%
=======================================
Files 115 115
Lines 3621 3621
Branches 675 675
=======================================
Hits 1629 1629
Misses 1969 1969
Partials 23 23 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comitted
./react/package-lock.jsonis switching betweenlockFileVersion1 and 2 (depending on which PR author the commits come from).We should as a project stick to one version. Since
lockFileVersion2 has been around sincenpm == 7(node 16) it should be safe to require this version.Something is not perfect with the current commited lock file in
master(dependabot complains about not being able to read it). Hopefully this PR fixes that.Note that an unmaintained
devDependencyneeds to be removed in order to create a consistentpackage.jsonfile, see #972.Closes #877 and closes #640.