Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code splitting with require.ensure. #1216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 83 additions & 33 deletions src/routes.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,5 @@
import React from 'react';
import {IndexRoute, Route} from 'react-router';
import { isLoaded as isAuthLoaded, load as loadAuth } from 'redux/modules/auth';
import {
App,
Chat,
Home,
Widgets,
About,
Login,
LoginSuccess,
Survey,
NotFound,
} from 'containers';

// import {Login} from 'containers';
export default (store) => {
const requireLogin = (nextState, replace, cb) => {
function checkAuth() {
Expand All @@ -30,29 +17,92 @@ export default (store) => {
checkAuth();
}
};

/**
* Please keep routes in alphabetical order
*/
return (
<Route path="/" component={App}>
{ /* Home (main) route */ }
<IndexRoute component={Home}/>
if (typeof require.ensure !== 'function') require.ensure = (deps, cb) => cb(require);

{ /* Routes requiring login */ }
<Route onEnter={requireLogin}>
<Route path="chat" component={Chat}/>
<Route path="loginSuccess" component={LoginSuccess}/>
</Route>
return {
path: '/',
component: require('./containers/App/App'),
indexRoute: {
component: require('./containers/Home/Home')
},
childRoutes: [{
path: 'login',
getComponent(nextState, cb) {
console.time('gettingComponent');
store.dispatch({
type: 'WEBPACK_LOAD'
});
require.ensure([], (require) => {
cb(null, require('./containers/Login/Login'));
store.dispatch({
type: 'WEBPACK_LOAD_END'
});
console.timeEnd('gettingComponent');
});
}

{ /* Routes */ }
<Route path="about" component={About}/>
<Route path="login" component={Login}/>
<Route path="survey" component={Survey}/>
<Route path="widgets" component={Widgets}/>
}, {
path: 'about',
getComponent(nextState, cb) {
console.time('gettingComponent');
store.dispatch({
type: 'WEBPACK_LOAD'
});
require.ensure([], (require) => {
cb(null, require('./containers/About/About'));
store.dispatch({
type: 'WEBPACK_LOAD_END'
});
console.timeEnd('gettingComponent');
});
}

{ /* Catch all route */ }
<Route path="*" component={NotFound} status={404} />
</Route>
);
}, {
path: 'survey',
getComponent(nextState, cb) {
require.ensure([], (require) =>
cb(null, require('./containers/Survey/Survey')));
}
}, {
path: 'widgets',
getComponent(nextState, cb) {
store.dispatch({
type: 'WEBPACK_LOAD'
});
require.ensure([], (require) => {
cb(null, require('./containers/Widgets/Widgets'));
store.dispatch({
type: 'WEBPACK_LOAD_END'
});
});
}
}, {
onEnter: requireLogin,
childRoutes: [
{
path: 'chat',
getComponent(nextState, cb) {
require.ensure([], (require) =>
cb(null, require('./containers/Chat/Chat')));
}
},
{
path: 'loginSuccess',
getComponent(nextState, cb) {
require.ensure([], (require) =>
cb(null, require('./containers/LoginSuccess/LoginSuccess')));
}
}
]
}, {
path: '*',
getComponent(nextState, cb) {
require.ensure([], (require) =>
cb(null, require('./containers/NotFound/NotFound')));
}
}]
};
};