Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API stuff from Melvyn #791

Closed
erincatto opened this issue Sep 5, 2024 · 3 comments
Closed

API stuff from Melvyn #791

erincatto opened this issue Sep 5, 2024 · 3 comments

Comments

@erincatto
Copy link
Owner

I'm curious about the b2DebugDraw::DrawCapsule function; will that be staying? I see it's only called from the test-bed currently.

API request Would it be possible to have the respective getters added for the following?
B2_API void b2World_EnableSleeping( b2WorldId worldId, bool flag );
B2_API void b2World_EnableContinuous( b2WorldId worldId, bool flag );
B2_API void b2World_SetRestitutionThreshold( b2WorldId worldId, float value );
B2_API void b2World_SetHitEventThreshold( b2WorldId worldId, float value );

Another thing, it would be great to be able to ask if the world is currently locked as opposed to hitting an assert which then begs the question if this should be an atomic flag? The atomics I'm less bothered about, access to the flag would be great though.

@MelvMay-Unity
Copy link

Just to add that warming-start getter is missing too:
B2_API void b2World_EnableWarmStarting( b2WorldId worldId, bool flag );

Thanks!

@MelvMay-Unity
Copy link

issue_791.patch
In-case it helps, I know you're busy!

erincatto added a commit that referenced this issue Sep 9, 2024
erincatto added a commit that referenced this issue Sep 9, 2024
Updated benchmarks for AMD Ryzen when new Windows 11 patch.

#788
#791
@erincatto
Copy link
Owner Author

Implemented in #787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants