Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix armeabi-v7a #814

Closed
wants to merge 1 commit into from
Closed

fix armeabi-v7a #814

wants to merge 1 commit into from

Conversation

bostick
Copy link

@bostick bostick commented Sep 30, 2024

Fix #813

Emulate vzip1q_f32 for 32-bit

Emulate vzip1q_f32 for 32-bit
@erincatto
Copy link
Owner

Thanks for this fix! Are you able to do any performance comparisons versus SIMD disabled on this platform? Just curious.

erincatto added a commit that referenced this pull request Oct 6, 2024
@erincatto erincatto mentioned this pull request Oct 6, 2024
@erincatto erincatto closed this in a7123be Oct 6, 2024
@bostick
Copy link
Author

bostick commented Oct 7, 2024

I have a 32-bit arm7 device I can test on. What comparisons would be good to do?

@bostick bostick deleted the fix-armeabi-v7a branch October 7, 2024 11:37
@bostick bostick restored the fix-armeabi-v7a branch October 7, 2024 11:37
@erincatto
Copy link
Owner

If you can run the benchmark app that would be great.

option(BOX2D_BENCHMARKS "Build the Box2D benchmarks" OFF)

@bostick
Copy link
Author

bostick commented Oct 7, 2024

OK, I will setup a simple Android app for running the benchmark.

@bostick
Copy link
Author

bostick commented Oct 8, 2024

OK @erincatto , I put up a repo with the results of running the benchmark:
https://github.com/bostick/Box2DAndroidBenchmark

I have not interpreted the results. Let me know if you'd like anything else

@erincatto
Copy link
Owner

image

It seems SIMD optimizations are not helping on this CPU. I've heard 32-bit Neon is not very good. I see good results on 64-bit Neon though. This CPU is also quite slow in general. But it does make sense to use around 4 threads on this.

Thanks a lot for running these tests!

@erincatto
Copy link
Owner

Fixed the formatting. You can see other benchmark results here: https://box2d.org/files/benchmark_results.html

image

@bostick
Copy link
Author

bostick commented Oct 9, 2024

Ah, I messed up the formatting when I stripped the \n in the fprintf calls when I was replacing all of printf calls with Android logging. Fixed in the repo now.

@bostick bostick deleted the fix-armeabi-v7a branch October 25, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box2D not building on armeabi-v7a
3 participants