Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't link to Google Fonts directly #22

Closed
afoeder opened this issue Jul 27, 2023 · 2 comments
Closed

Don't link to Google Fonts directly #22

afoeder opened this issue Jul 27, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request released

Comments

@afoeder
Copy link

afoeder commented Jul 27, 2023

The CSS deeplinks/imports the Google Fonts directly from Google, see both

@import url('https://fonts.googleapis.com/css?family=Montserrat:400,600');
@import url('https://fonts.googleapis.com/css?family=Lora');

@import url("https://fonts.googleapis.com/css?family=Montserrat:400,600");
@import url("https://fonts.googleapis.com/css?family=Lora");

This is at least in GDPR countries unfortunately and completely stupidly not a good thing anymore and led to adhortatory letters (🇩🇪 "Abmahnungen"). I also accidentally almost published the site.
I think it makes sense to locally copy the fonts to this project and serve them from here.

I could take care, however some thoughts about how the crediting, mentioning should look like to be sufficient would be nice. Does it have to be present at the footer line?

@escalate escalate self-assigned this Nov 18, 2023
@escalate escalate added the enhancement New feature or request label Nov 18, 2023
@escalate
Copy link
Owner

Hello @afoeder,

you are welcome to submit an MR for implementation.

Best regards
Felix

escalate added a commit that referenced this issue May 31, 2024
escalate added a commit that referenced this issue May 31, 2024
escalate added a commit that referenced this issue May 31, 2024
escalate added a commit that referenced this issue May 31, 2024
escalate added a commit that referenced this issue May 31, 2024
escalate added a commit that referenced this issue May 31, 2024
Copy link

github-actions bot commented Jun 1, 2024

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants