forked from christianmendoza/hugo-split-theme
-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't link to Google Fonts directly #22
Labels
Comments
Hello @afoeder, you are welcome to submit an MR for implementation. Best regards |
🎉 This issue has been resolved in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The CSS deeplinks/imports the Google Fonts directly from Google, see both
hugo-split-theme/static/assets/sass/01-content.scss
Lines 5 to 6 in bc49ceb
hugo-split-theme/static/assets/css/split.css
Lines 9 to 10 in bc49ceb
This is at least in GDPR countries unfortunately and completely stupidly not a good thing anymore and led to adhortatory letters (🇩🇪 "Abmahnungen"). I also accidentally almost published the site.
I think it makes sense to locally copy the fonts to this project and serve them from here.
I could take care, however some thoughts about how the crediting, mentioning should look like to be sufficient would be nice. Does it have to be present at the footer line?
The text was updated successfully, but these errors were encountered: