Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array views in spin functions #2

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Jul 20, 2023

This should reduce some memory allocation

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -3.66 ⚠️

Comparison is base (3d6990d) 66.77% compared to head (7b108bb) 63.12%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   66.77%   63.12%   -3.66%     
==========================================
  Files           4        4              
  Lines         301      301              
==========================================
- Hits          201      190      -11     
- Misses        100      111      +11     
Impacted Files Coverage Δ
src/spin.jl 92.50% <100.00%> (-6.25%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eschnett eschnett merged commit 9f4462d into eschnett:main Jul 20, 2023
@eschnett
Copy link
Owner

Thank you! I was not aware of the convenient @views macro, and didn't spot the places where the previous code had unnecessary allocations.

@jishnub jishnub deleted the views branch July 20, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants