Remove most PSRAM features #2178
Merged
+513
−380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
requested changes
Sep 17, 2024
MabezDev
reviewed
Sep 17, 2024
bjoernQ
force-pushed
the
esp-hal/remove-psram-features
branch
from
f28878a to
161c546
Compare
|
|
MabezDev
reviewed
Sep 18, 2024
bjoernQ
force-pushed
the
esp-hal/remove-psram-features
branch
from
fde90d5 to
3fe55f6
Compare
Dominaezzz
reviewed
Sep 18, 2024
MabezDev
requested changes
Sep 19, 2024
bjoernQ
force-pushed
the
esp-hal/remove-psram-features
branch
from
03a10f7 to
f1d0a51
Compare
MabezDev
reviewed
Sep 19, 2024
MabezDev
reviewed
Sep 19, 2024
|
Let's rebase this on @bugadani's lock changes, after that this looks good to go! |
bjoernQ
force-pushed
the
esp-hal/remove-psram-features
branch
from
f9977a4 to
06f8606
Compare
Dominaezzz
reviewed
Sep 20, 2024
MabezDev
reviewed
Sep 20, 2024
MabezDev
approved these changes
Sep 20, 2024
Co-authored-by: Scott Mabin <[email protected]>
jessebraham
approved these changes
Sep 20, 2024
bugadani
reviewed
Sep 20, 2024
|
|
||
| let guessed_size = unsafe { | ||
| let ptr = (EXTMEM_ORIGIN + 4 * 1024 * 1024 - 36 * 1024) as *mut u8; | ||
| for i in 0..(36 * 1024) { |
There was a problem hiding this comment.
Why 36K? Please explain the choice, and can we do away with scanning these blocks fully?
There was a problem hiding this comment.
Idea is to write and read more than fits the cache
Ideally we get reading the chip id to work - that would be the best solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
This gets rid of most of the PSRAM related features. We still need
psramandoctal-psramhoweverThis also adds auto-detection of PSRAM size (by using the RAM chip id on S2/S3, just probing memory on ESP32 since reading the chip id didn't work as expected)
The user now needs to pass a configuration parameter to psram_initialize - this way they could avoid RAM size auto-detect and configure things like the PSRAM SPI frequency
Testing
Examples still work