Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the newly-released crates; use ESP IDF V5.3 (latest stable) and V5.2 (previous stable) #254

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

ivmarkov
Copy link
Collaborator

@ivmarkov ivmarkov commented Jan 2, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • [v] I have updated existing examples or added new ones (if applicable).
  • [v] I have used cargo fmt command to ensure that all changed code is formatted correctly.
  • [v] I have used cargo clippy command to ensure that all changed code passes latest Clippy nightly lints.
  • [v] My changes were added to the CHANGELOG.md in the proper section.

Pull Request Details 📖

Description

As per the subject:

  • esp-idf-svc (and embuild) updated to the just-released versions
  • Since we finally can build ourselves against latest stable ESP-IDF, the template is changed to offer by default V5.3, and then V5.2 as a backup, and master for the brave ones, as usu.

Testing

The CI would test it all!

@ivmarkov ivmarkov marked this pull request as ready for review January 2, 2025 14:35
@ivmarkov ivmarkov requested a review from SergioGasquez January 2, 2025 14:49
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing the releases and updating the template! Just one small question

@ivmarkov ivmarkov merged commit 8d07929 into master Jan 2, 2025
25 checks passed
@SergioGasquez SergioGasquez deleted the new-release2 branch January 2, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants