-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mise à jour Phoenix LiveView de 0.3.0 à 0.14.0 #1431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a deprecation warning which is mentioned in their changelog.
Starting from 0.14.1, we'll need to upgrade Phoenix too, something that will go in a different PR.
thbar
commented
Jan 5, 2021
thbar
commented
Jan 5, 2021
@antoine-de je n'arrive pas à t'ajouter en reviewer, c'est curieux ! |
étrange 🤔 |
antoine-de
approved these changes
Jan 6, 2021
We only need to make sure it is at least 64-bytes long.
J'ai ajouté un petit check pour nous prévenir des upgrades manquantes de la partie javascript, et je déploie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatif à #1423 ; je commence une spike pour mettre à jour cette partie qui vu le changelog nécessite quelques itérations.
Tâches à prévoir
Ajouter un ou deux tests (qui auraient détecté la casse en passage à 0.5.x)- je pense que ça peut attendre plus tard (autre PR de mise à jour à 0.15.x future)Notes d'upgrade
cd cd apps/transport/client && yarn upgrade phoenix_live_view
(vérifier dansyarn.lock
la version dephoenix_live_view
)