Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mise à jour ymlr et open_api_spex #3813

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Mise à jour ymlr et open_api_spex #3813

merged 2 commits into from
Mar 18, 2024

Conversation

thbar
Copy link
Contributor

@thbar thbar commented Mar 15, 2024

Voir:

La mise à jour de ymlr posait un souci à cause de:

Qui avait été mergé, mais il manquait une release, j'ai été pinger le mainteneur ici:

Et il a bien voulu faire une petite release pour ça, ce qui me permet de proposer la présente PR.

Changelogs

(généré via elixir generate_deps_changelogs.exs)

Je vais faire quelques tests manuels en local avant de proposer la review.

@thbar thbar changed the title Mise à jour ymlr et open_api_sex Mise à jour ymlr et open_api_spex Mar 15, 2024
@thbar
Copy link
Contributor Author

thbar commented Mar 15, 2024

J'ai été regarder du côté de:

et je n'ai pas vu de souci.

@thbar thbar marked this pull request as ready for review March 15, 2024 13:15
@thbar thbar requested a review from a team as a code owner March 15, 2024 13:15
@thbar
Copy link
Contributor Author

thbar commented Mar 15, 2024

Pas de souci non plus sur prochainement, du coup je passe en merge when ready.

@thbar thbar enabled auto-merge March 15, 2024 13:34
@AntoineAugusti AntoineAugusti disabled auto-merge March 15, 2024 13:34
Copy link
Member

@AntoineAugusti AntoineAugusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Je désactive l'auto merge, à merger semaine prochaine au calme ?

@thbar
Copy link
Contributor Author

thbar commented Mar 15, 2024

Je désactive l'auto merge, à merger semaine prochaine au calme ?

Yes !

@thbar
Copy link
Contributor Author

thbar commented Mar 18, 2024

Je déploie 😄 fingers crossed

@thbar thbar added this pull request to the merge queue Mar 18, 2024
Merged via the queue into master with commit b273a49 Mar 18, 2024
4 checks passed
@thbar thbar deleted the upgrade-ymlr branch March 18, 2024 13:41
@@ -103,7 +103,7 @@
"postgrex": {:hex, :postgrex, "0.16.5", "fcc4035cc90e23933c5d69a9cd686e329469446ef7abba2cf70f08e2c4b69810", [:mix], [{:connection, "~> 1.1", [hex: :connection, repo: "hexpm", optional: false]}, {:db_connection, "~> 2.1", [hex: :db_connection, repo: "hexpm", optional: false]}, {:decimal, "~> 1.5 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:table, "~> 0.1.0", [hex: :table, repo: "hexpm", optional: true]}], "hexpm", "edead639dc6e882618c01d8fc891214c481ab9a3788dfe38dd5e37fd1d5fb2e8"},
"protobuf": {:hex, :protobuf, "0.12.0", "58c0dfea5f929b96b5aa54ec02b7130688f09d2de5ddc521d696eec2a015b223", [:mix], [{:jason, "~> 1.2", [hex: :jason, repo: "hexpm", optional: true]}], "hexpm", "75fa6cbf262062073dd51be44dd0ab940500e18386a6c4e87d5819a58964dc45"},
"quantum": {:hex, :quantum, "3.5.0", "8d2c5ba68c55991e8975aca368e3ab844ba01f4b87c4185a7403280e2c99cf34", [:mix], [{:crontab, "~> 1.1", [hex: :crontab, repo: "hexpm", optional: false]}, {:gen_stage, "~> 0.14 or ~> 1.0", [hex: :gen_stage, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:telemetry_registry, "~> 0.2", [hex: :telemetry_registry, repo: "hexpm", optional: false]}], "hexpm", "cab737d1d9779f43cb1d701f46dd05ea58146fd96238d91c9e0da662c1982bb6"},
"rambo": {:hex, :rambo, "0.3.4", "8962ac3bd1a633ee9d0e8b44373c7913e3ce3d875b4151dcd060886092d2dce7", [:mix], [], "hexpm", "0cc54ed089fbbc84b65f4b8a774224ebfe60e5c80186fafc7910b3e379ad58f1"},
"rambo": {:git, "https://github.com/myobie/rambo.git", "e321db8e4f035f2a295ee2a5310dcb75034677ce", [ref: "e321db8e4f035f2a295ee2a5310dcb75034677ce"]},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ceci n'aurait pas dû être modifié je pense.

Lié à ça ?

if apple_silicon?() do
# branch is "aarch64-apple" but we're hardcoding the ref for security, especially since `mix.lock`
# must not be committed in that case.
# NOTE: this is not enough, and a manual `mix compile.rambo` must be issued manually in order
# for this to work (https://github.com/jayjun/rambo/pull/13#issuecomment-1189194040).
{:rambo, "~> 0.3.4",
github: "myobie/rambo", ref: "e321db8e4f035f2a295ee2a5310dcb75034677ce"}
else
{:rambo, "~> 0.3.4"}
end,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je vais traiter merci ! Bien vu !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci, j'ai créé ce ticket et je suis en train de préparer une PR hotfix:

thbar added a commit that referenced this pull request Mar 18, 2024
thbar added a commit that referenced this pull request Mar 21, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 22, 2024
* Bump up ymlr & open_api_spex

* Bump up most libs

* Fix unvoluntary update I introduced in #3813

Hat-tip to @AntoineAugusti (#3813 (comment))

* Bump appsignal

* Bump ex_aws

* Bump floki

* Bump image

* Bump swoosh

* Bump sentry

* Bump telemetry_metrics (no changes)

* Bump telemetry_metrics (no changes)

* Update yarn.lock

* Add note

* Force deploy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants