Update latest signer for optimism to prague #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
reviewed
Mar 6, 2025
|
Do we also want to update |
@tynes this seems more complex, because this function only receives the chain id and not the chain config. So you cannot know whether it's an optimism chain within the context of this function. In that case, the most permissive signer is still the prague signer. So I think it's fine to leave it as is. We also didn't add any extra logic into that function before, e.g. also would return a blobtx signer before Isthmus. |
sebastianst
approved these changes
Mar 7, 2025
sebastianst
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These should be returning the most permissive signer available for the given chain config. For Isthmus, we need to make sure SetCodeTx transactions are supported.
This logic probably originally existed because Cancun signer only supports blob txs.