Skip to content

Commit

Permalink
fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
cody-wang-cb committed May 14, 2024
1 parent 760b8c9 commit 4926e1c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
10 changes: 1 addition & 9 deletions op-e2e/brotli_batcher_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,6 @@ import (
"github.com/ethereum-optimism/optimism/op-service/testlog"
)

// TestSystem4844E2E runs the SystemE2E test with 4844 enabled on L1,
// and active on the rollup in the op-batcher and verifier.
// func TestSystem4844E2E(t *testing.T) {
// t.Run("single-blob", func(t *testing.T) { testSystem4844E2E(t, false) })
// t.Run("multi-blob", func(t *testing.T) { testSystem4844E2E(t, true) })
// }

func setupAliceAccount(t *testing.T, cfg SystemConfig, sys *System, ethPrivKey *ecdsa.PrivateKey) {
l1Client := sys.Clients["l1"]
l2Verif := sys.Clients["verifier"]
Expand Down Expand Up @@ -141,10 +134,9 @@ func TestBrotliBatcherFjord(t *testing.T) {
require.NoError(t, err)
_, err = gethutils.FindBlock(l1Client, int(tip.Number.Int64()), 0, 5*time.Second,
func(b *types.Block) (bool, error) {
// Check that the transaction exists in the L1 block
// check that the transaction exists in the L1 block
require.Equal(t, b.Transactions().Len(), 1)
return true, nil
})
require.NoError(t, err)

}
3 changes: 1 addition & 2 deletions op-e2e/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -827,9 +827,8 @@ func (cfg SystemConfig) Start(t *testing.T, _opts ...SystemConfigOption) (*Syste
}

var compressionAlgo derive.CompressionAlgo = derive.Zlib
// If setting has brotli key, set the compression algo as brotli
// if opt has brotli key, set the compression algo as brotli
if _, ok := opts.Get("compressionAlgo", "brotli"); ok {
fmt.Println("setting as brotli")
compressionAlgo = derive.Brotli10
}

Expand Down

0 comments on commit 4926e1c

Please sign in to comment.