Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: cleanup error-handling in derivation #10725

Open
protolambda opened this issue Jun 3, 2024 · 0 comments
Open

op-node: cleanup error-handling in derivation #10725

protolambda opened this issue Jun 3, 2024 · 0 comments
Assignees
Labels
A-op-node Area: op-node

Comments

@protolambda
Copy link
Contributor

During the refactor of the derivation/driver code (See #10599) @ajsutton identified that the error handling is difficult to follow / getting dropped silently in some cases.

Separate from the initial refactor work we can change it to more clearly branch/return, and handle all error cases (even if the errors are not critical, at least they can be logged).

See:

  • errors returned by TryBackupUnsafeReorg
  • errors returned by TryUpdateEngine
  • the return-if-not-EOF (nil or non-EOF error) cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-node Area: op-node
Projects
None yet
Development

No branches or pull requests

1 participant