-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: extract unsafe-block processing from derivation code-path #10599
Conversation
Semgrep found 2 No |
d9f1845
to
06e3ba3
Compare
Semgrep found 2 Variable Semgrep found 1 Please create a GitHub ticket for this TODO. Ignore this finding from todos_require_linear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Really just Boy Scout, make the place a little better suggestions.
f0e24a6
to
975def6
Compare
06e3ba3
to
113cde7
Compare
Rebased on new |
113cde7
to
22c10ae
Compare
Rebased on develop, dependency PR landed. |
Description
Extracts the unsafe-block processing code-path from the
EngineQueue
and encapsulates it in a newclsync
package. It buffers unsafe blocks, and applies as necessary, for step-wise CL sync.The EL-sync is triggered as before still, upon new payloads received from gossip, not using the CL sync code-path.
This PR depends on #10580
Marked as do-not-merge until dependency is merged into
develop
.This is the second step towards removal of the EngineQueue in favor of a more encapsulated pure derivation pipeline.
Tests
Adds missing unit tests: previously only the act of dropping an older unsafe block was tested.
Now it tests all combinations of existing unsafe head vs new unsafe payloads.
Metadata
Fix https://github.com/ethereum-optimism/protocol-quest/issues/270