Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Fjord devnet activation #10573

Merged
merged 2 commits into from
May 16, 2024
Merged

Enable Fjord devnet activation #10573

merged 2 commits into from
May 16, 2024

Conversation

sebastianst
Copy link
Member

Description

Enable Fjord devnet activation via superchain-registry and op-geht go mod updated.

@sebastianst sebastianst enabled auto-merge May 16, 2024 21:55
@sebastianst sebastianst requested a review from a team as a code owner May 16, 2024 22:05
@sebastianst sebastianst requested a review from geoknee May 16, 2024 22:05
Copy link
Contributor

coderabbitai bot commented May 16, 2024

Walkthrough

Walkthrough

This change introduces a new field, FjordTime, to the sepoliaDev0Cfg configuration within the chains_test.go file. The addition is aimed at enhancing the configuration capabilities for testing purposes in the op-node project.

Changes

Files Change Summary
op-node/chaincfg/chains_test.go Added the FjordTime field to the sepoliaDev0Cfg configuration struct.

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8377204 and 456ee0f.
Files ignored due to path filters (4)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
  • op-ufm/go.mod is excluded by !**/*.mod
  • op-ufm/go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • op-node/chaincfg/chains_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • op-node/chaincfg/chains_test.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sebastianst sebastianst added this pull request to the merge queue May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (8377204) to head (456ee0f).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10573       +/-   ##
============================================
+ Coverage    42.36%   81.92%   +39.55%     
============================================
  Files           73       10       -63     
  Lines         4836     1079     -3757     
  Branches       766        0      -766     
============================================
- Hits          2049      884     -1165     
+ Misses        2680      163     -2517     
+ Partials       107       32       -75     
Flag Coverage Δ
cannon-go-tests 81.92% <ø> (ø)
chain-mon-tests ?
common-ts-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes

Merged via the queue into develop with commit 40eee4f May 16, 2024
72 checks passed
@sebastianst sebastianst deleted the seb/fjord-devnet branch May 16, 2024 22:45
rdovgan pushed a commit to rdovgan/optimism that referenced this pull request Jun 24, 2024
* Enable Fjord devnet activation

* chaincfg: add Fjord time to sepolia-devnet-0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants