op-node: Support multiple beacon archiver/fallbacks #10655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
sebastianst
requested review from
axelKingsley and
trianglesphere
and removed request for
refcell
ajsutton
reviewed
May 27, 2024
felipe-op
approved these changes
May 28, 2024
sebastianst
commented
May 29, 2024
- retain old flag name and env var - fix some tests
Co-authored-by: Adrian Sutton <[email protected]>
sebastianst
force-pushed
the
seb/beacon-multi-fallback
branch
from
c97fd8d to
0917e57
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rdovgan
pushed a commit
to rdovgan/optimism
that referenced
this pull request
Jun 24, 2024
…m#10655) * op-node: Support multiple beacon archiver/fallbacks * op-node: rename flag to l1.beacon-fallbacks - retain old flag name and env var - fix some tests * Update op-node/node/client_test.go Co-authored-by: Adrian Sutton <[email protected]> --------- Co-authored-by: Adrian Sutton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for specifying multiple beacon fallbacks/archivers via op-node's cmdline flags. The underlying support in the L1 Beacon client was already there, this just adds support for parsing multiple comma-separated endpoint addresses from the
l1.beacon-archiverflag.The flag is also renamed to
l1.beacon-fallbacks, but the old name is preserved as an alias for backwards compatibility.Tests
Added test that the string parsing works as expected and creates multiple L1 beacon http clients. The underlying fallback logic is already tested in its own tests.
Additional context
With this addition, the
l1.beacon-archiverflag can be used to provide a list of fallback beacon l1 clients, instead of just falling back between the mainl1.beaconendpoint and the one endpoint specified inl1.beacon-archiver.