Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: semgrep rules and check for reinitializer modifiers #14534

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

smartcontracts
Copy link
Contributor

Adds semgrep rules and a new golang contracts check for reinitializer modifiers. Important safety checks now that we are using upgrade functions.

@smartcontracts smartcontracts requested review from a team as code owners February 26, 2025 00:07
@smartcontracts smartcontracts requested review from tynes, axelKingsley and mslipper and removed request for tynes and axelKingsley February 26, 2025 00:07
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 72.36842% with 21 lines in your changes missing coverage. Please review.

Project coverage is 46.49%. Comparing base (f45e785) to head (d5e28ee).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...racts-bedrock/scripts/checks/reinitializer/main.go 72.36% 20 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14534      +/-   ##
===========================================
- Coverage    46.60%   46.49%   -0.12%     
===========================================
  Files         1033     1034       +1     
  Lines        88579    88655      +76     
===========================================
- Hits         41281    41218      -63     
- Misses       44210    44359     +149     
+ Partials      3088     3078      -10     
Flag Coverage Δ
cannon-go-tests-32 61.92% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.56% <ø> (-1.65%) ⬇️
contracts-bedrock-tests 94.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-chain-ops/solc/types.go 12.50% <ø> (ø)
...racts-bedrock/scripts/checks/reinitializer/main.go 72.36% <72.36%> (ø)

... and 16 files with indirect coverage changes

@smartcontracts smartcontracts force-pushed the sc/reinitializer-rules branch 2 times, most recently from 9445416 to 609b825 Compare February 26, 2025 00:24
@smartcontracts smartcontracts force-pushed the sc/reinitializer-rules branch 2 times, most recently from 6479969 to bc1e1b6 Compare February 26, 2025 14:43
@smartcontracts smartcontracts added this pull request to the merge queue Feb 26, 2025
@smartcontracts smartcontracts removed this pull request from the merge queue due to a manual request Feb 26, 2025
Adds semgrep rules and a new golang contracts check for
reinitializer modifiers. Important safety checks now that we are
using upgrade functions.
@smartcontracts smartcontracts added this pull request to the merge queue Feb 26, 2025
Merged via the queue into develop with commit 4ef678a Feb 26, 2025
46 checks passed
@smartcontracts smartcontracts deleted the sc/reinitializer-rules branch February 26, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants