Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated eip-1679 to contain eip-1108 #1988

Merged
merged 2 commits into from
May 9, 2019
Merged

updated eip-1679 to contain eip-1108 #1988

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49263ce
updated eip-1679 to contain eip-1108
zac-williamson May 3, 2019
4a91acc
Update eip-1679.md
zac-williamson May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions EIPS/eip-1679.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ This meta-EIP specifies the changes included in the Ethereum hardfork named Ista
[pending audit](https://medium.com/ethereum-cat-herders/progpow-audit-goals-expectations-75bb902a1f01),
above and beyond standard security considerations, that should be evaluated
prior to inclusion.
- [EIP-1108](https://eips.ethereum.org/EIPS/eip-1108): Reduce alt_bn128 precompile gas costs
- There is currently an outstanding [pull request](https://github.com/ethereum/EIPs/pull/1987) that updates the gas costs to the latest benchmarks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we merge #1987 first, remove this comment and merge this to avoid the extra PRs needed to remove this line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merged that guy, so it looks like @zac-williamson you just need to drop the note on line 38 and we're maybe good to go here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zac-williamson can you please do that? I'd like to merge this.

- [EIP-1344](https://eips.ethereum.org/EIPS/eip-1344): Add ChainID opcode
- [EIP-1352](https://eips.ethereum.org/EIPS/eip-1352): Specify restricted address range for precompiles/system contracts
- [EIP-1380](https://eips.ethereum.org/EIPS/eip-1380): Reduced gas cost for call to self
Expand Down