-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-2384 to Final Status #2447
Conversation
2384 was formally added to Muir Glacier and at least 3 core clients have implemented.
Update EIP-2384 to Last Call Status
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
Ping @econoar for when you get back from Fiji...slacker. |
This shouldn't have been merged, since on the last ACD calls it was agreed that it needs to be clarified in regards to miner's fees. |
For future reference, I do not consider this to be a model for promoting Last Calls to Finals (or Accepteds). "Clients implemented it" is insufficient explanation for exiting Last Call. Here is a model for a good promotion pull request. Additionally, Ethereum Foundation publicly endorsed this EIP as Final before it left Last Call. Such is poor precedent. That is discussed at https://eips.ethereum.org/EIPS/eip-2384 Let's do better next time. |
@axic @fulldecent Fair point re review-period-end. When the EIP is already in a scheduled hard fork released by multiple clients, though, it's to all intents and purposes final - there's no plausible way for changes to it to be made. |
To be clear, I am mostly criticizing the client developers on this one. And yes, in the prior hard fork the the scheduled hard fork released by multiple clients was reversed and changes were made afterwards. https://blog.ethereum.org/2019/01/15/security-alert-ethereum-constantinople-postponement/ |
2384 was formally added to Muir Glacier and at least 3 core clients have implemented.
2384 was formally added to Muir Glacier and at least 3 core clients have implemented.
Move #2384 to Final from Last Call as three core clients have already implemented. Note: this would skip accepted but that is as a matter of formality due to the oversight in progressing the EIP prior to client teams implementing.