Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-2384 to Final Status #2447

Merged
merged 2 commits into from
Dec 24, 2019
Merged

Conversation

cyber-hokie
Copy link
Contributor

Move #2384 to Final from Last Call as three core clients have already implemented. Note: this would skip accepted but that is as a matter of formality due to the oversight in progressing the EIP prior to client teams implementing.

2384 was formally added to Muir Glacier and at least 3 core clients have implemented.
Update EIP-2384 to Last Call Status
@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 2384 state from Last Call to Final
  • EIP 2384 requires approval from one of (@econoar)

@cyber-hokie
Copy link
Contributor Author

Ping @econoar for when you get back from Fiji...slacker.

@Arachnid Arachnid merged commit 0104c3a into ethereum:master Dec 24, 2019
@axic
Copy link
Member

axic commented Dec 24, 2019

This shouldn't have been merged, since on the last ACD calls it was agreed that it needs to be clarified in regards to miner's fees.

@axic
Copy link
Member

axic commented Dec 27, 2019

This also failed to remove the review-period-end field and now this is the render:
Screenshot 2019-12-27 at 11 39 00

@axic axic mentioned this pull request Dec 27, 2019
@fulldecent
Copy link
Contributor

For future reference, I do not consider this to be a model for promoting Last Calls to Finals (or Accepteds).

"Clients implemented it" is insufficient explanation for exiting Last Call.


Here is a model for a good promotion pull request.

#1170


Additionally, Ethereum Foundation publicly endorsed this EIP as Final before it left Last Call. Such is poor precedent. That is discussed at https://eips.ethereum.org/EIPS/eip-2384


Let's do better next time.

@Arachnid
Copy link
Contributor

Arachnid commented Jan 2, 2020

@axic @fulldecent Fair point re review-period-end. When the EIP is already in a scheduled hard fork released by multiple clients, though, it's to all intents and purposes final - there's no plausible way for changes to it to be made.

@fulldecent
Copy link
Contributor

To be clear, I am mostly criticizing the client developers on this one.

And yes, in the prior hard fork the the scheduled hard fork released by multiple clients was reversed and changes were made afterwards. https://blog.ethereum.org/2019/01/15/security-alert-ethereum-constantinople-postponement/

tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
2384 was formally added to Muir Glacier and at least 3 core clients have implemented.
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
2384 was formally added to Muir Glacier and at least 3 core clients have implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants