Create EIP for a ERC-721, ERC-1155 to ERC-20 Wrapper (#3386) #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashrowz
changed the title
…arameter from mints, added reference implementation
lightclient
requested changes
Apr 15, 2021
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): |
lightclient
approved these changes
May 18, 2021
maorstamati
reviewed
Nov 1, 2021
| event BurnSingle (address indexed _from, address indexed _to, uint256 _id, uint256 _amount, uint256 _value); | ||
|
|
||
| /** | ||
| * @dev MUST emit when a mint occurs where multiple {Base} tokens are sent by the {Wrapper}. |
There was a problem hiding this comment.
Shouldn't it be "MUST emit when a burn occurs where multiple {Base} tokens are sent by the {Wrapper}."?
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
…thereum#3386) * Create EIP for a ERC-721, ERC-1155 to ERC-20 Wrapper (ethereum#3384) * Fixed EIP number (ethereum#3386) * Fixed spelling * Removed syntax errors. * Upgraded interface to solidity v0.8.0, fixed typos, removed `_from` parameter from mints, added reference implementation * Apply suggestions from code review Co-authored-by: lightclient <[email protected]> * Added inline hyperlinks, removed unneeded list of links at the end. * Simplified the abstract. Co-authored-by: Calvin Koder <[email protected]> Co-authored-by: lightclient <[email protected]>
|
realized same idea: https://github.com/stanta/Wrap721to20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a standard interface for wrapping ERC-721 and ERC-1155 tokens with derivative ERC-20 tokens.