Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-7160: Move to Last Call #34

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

mpeyfuss
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions
Copy link

The commit d019678 (as a parent of d222662) contains errors.
Please inspect the Run Summary for details.

@mpeyfuss
Copy link
Contributor Author

@SamWilsn I've migrated my PR from the EIPs repo here - doesn't seem possible to pass the html proofer

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Nov 11, 2023

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Last Call for ERC-7160 Update ERC-7160: Move to Last Call Nov 11, 2023
@mpeyfuss
Copy link
Contributor Author

@SamWilsn @Pandapip1 @axic @xinbenlv could I get a review on this please?

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder to triple check your ERC-165 interface id before going to final.

@eip-review-bot eip-review-bot enabled auto-merge (squash) November 14, 2023 15:56
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit a6132a0 into ethereum:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants