Update ERC-7540: Move to Review #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieronx
approved these changes
Oct 27, 2023
|
@eth-bot rerun |
This was referenced Oct 31, 2023
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
Joeysantoro
commented
Nov 13, 2023
|
✅ All reviewers have approved. |
eip-review-bot
changed the title
SamWilsn
previously approved these changes
Nov 14, 2023
eip-review-bot
approved these changes
Nov 14, 2023
eip-review-bot
approved these changes
Nov 14, 2023
eip-review-bot
approved these changes
Nov 14, 2023
Pandapip1
suggested changes
Nov 14, 2023
eip-review-bot
previously approved these changes
Nov 14, 2023
Co-authored-by: Gavin John <[email protected]>
auto-merge was automatically disabled
November 14, 2023 17:38
Head branch was pushed to by a user without write access
Joeysantoro
dismissed stale reviews from eip-review-bot and SamWilsn
via
3a5828b
Co-authored-by: Gavin John <[email protected]>
|
The commit 28cec7d (as a parent of 9e2bac6) contains errors. |
Pandapip1
approved these changes
Nov 15, 2023
eip-review-bot
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses comments from https://ethereum-magicians.org/t/eip-7540-asynchronous-erc-4626-tokenized-vaults/16153 and transitions the EIP to
Reviewstatus