Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Code Index #542

Merged
merged 31 commits into from
Sep 3, 2024
Merged

Add ERC: Code Index #542

merged 31 commits into from
Sep 3, 2024

Conversation

peersky
Copy link
Contributor

@peersky peersky commented Jul 16, 2024

No description provided.

@peersky peersky requested a review from eip-review-bot as a code owner July 16, 2024 18:39
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jul 16, 2024

✅ All reviewers have approved.

@github-actions github-actions bot added the w-ci label Jul 16, 2024
@eip-review-bot eip-review-bot changed the title Add ERC: Code index Add ERC: Code Index Jul 16, 2024
@peersky peersky requested a review from abcoathup July 17, 2024 09:02
@github-actions github-actions bot removed the w-ci label Jul 17, 2024
@github-actions github-actions bot added the w-ci label Jul 17, 2024
@peersky
Copy link
Contributor Author

peersky commented Jul 23, 2024

@abcoathup Im not really sure how to fix the HTMLProofer CI error, it seems that it might look for a wrong directory path (erc/eip?), could you let me know if any action needed from me?

Co-authored-by: Sam Wilson <[email protected]>
@github-actions github-actions bot removed the w-ci label Jul 23, 2024
Copy link

github-actions bot commented Aug 2, 2024

The commit 53e4a52 (as a parent of 83136e3) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Aug 2, 2024
@github-actions github-actions bot removed the w-ci label Aug 7, 2024
@peersky peersky requested a review from SamWilsn August 23, 2024 11:36
ERCS/erc-7744.md Outdated

Consider a security auditor who wants to attest to the integrity of a contract's code. By referencing bytecode hashes, auditors can focus their audit on the bytecode itself, without needing to assess deployment parameters or storage contents. This method verifies the integrity of a contract's codebase without auditing the entire contract state.

Additionally, a bytecode referencing allows whitelist contracts before deployment, allowing developers to get pre-approval for their codebase without disclosing the code itself, or even pre-setup infrastructure that will change it behavior upon adding some determined functionality on chain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Additionally, a bytecode referencing allows whitelist contracts before deployment, allowing developers to get pre-approval for their codebase without disclosing the code itself, or even pre-setup infrastructure that will change it behavior upon adding some determined functionality on chain.
Additionally, bytecode referencing allows whitelist contracts before deployment, allowing developers to get pre-approval for their codebase without disclosing the code itself, or even pre-setup infrastructure that will change it behavior upon adding some determined functionality on chain.

ERCS/erc-7744.md Outdated
Comment on lines 110 to 111
For mor thorough implementation, you can refer to the Ethereum Distribution System (EDS):
`https://github.com/peeramid-labs/eds`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For mor thorough implementation, you can refer to the Ethereum Distribution System (EDS):
`https://github.com/peeramid-labs/eds`

Please remove this external link.

@eip-review-bot eip-review-bot enabled auto-merge (squash) September 3, 2024 14:13
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 1aaec25 into ethereum:master Sep 3, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants