Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-7208: Move to Final #859

Merged
merged 68 commits into from
Jan 24, 2025
Merged

Conversation

galimba
Copy link
Contributor

@galimba galimba commented Jan 20, 2025

Since we passed the last call period, we would like to request the move to Final.

The audit report is here

An example reference implementation is here

Special thanks to Omniscia for their contributions.

pash7ka and others added 30 commits December 4, 2023 14:55
erc-7208 update: removed todo

erc-7208 update: update metadata provider interface

erc-7208 update: add mutation types
ERC7208:update Abstract

ERC7208:update Motivation

ERC7208:update interfaces

ERC7208:update rationale

ERC7208:update grammar

ERC7208:update assets

ERC7208:update reference implementation

ERC7208:update removed erc721 dependency

ERC7208:update fix comment

ERC7208:update fixes to interfaces

ERC7208:update fixes to interfaces

ERC7208:update fixes to interfaces

ERC7208:update fixes to rationale

ERC7208:update fixes to implementation
erc7208 update: grammar fix

erc7208 update: grammar fix
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jan 20, 2025

✅ All reviewers have approved.

Copy link

The commit 966f2ed (as a parent of e03f8c9) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Jan 21, 2025
@github-actions github-actions bot removed the w-ci label Jan 21, 2025
@eip-review-bot eip-review-bot enabled auto-merge (squash) January 24, 2025 20:21
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit dcb587b into ethereum:master Jan 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants