-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-7208: Move to Final #859
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sam Wilson <[email protected]>
erc-7208 update: removed todo erc-7208 update: update metadata provider interface erc-7208 update: add mutation types
ERC7208:update Abstract ERC7208:update Motivation ERC7208:update interfaces ERC7208:update rationale ERC7208:update grammar ERC7208:update assets ERC7208:update reference implementation ERC7208:update removed erc721 dependency ERC7208:update fix comment ERC7208:update fixes to interfaces ERC7208:update fixes to interfaces ERC7208:update fixes to interfaces ERC7208:update fixes to rationale ERC7208:update fixes to implementation
erc7208 update: grammar fix erc7208 update: grammar fix
✅ All reviewers have approved. |
31 tasks
The commit 966f2ed (as a parent of e03f8c9) contains errors. |
SamWilsn
approved these changes
Jan 24, 2025
eip-review-bot
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we passed the last call period, we would like to request the move to
Final
.The audit report is here
An example reference implementation is here
Special thanks to Omniscia for their contributions.