Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue with find_space_after returning None #537

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

indmind
Copy link
Contributor

@indmind indmind commented Feb 19, 2025

There was a problem in the find_space_after function: if no space was found after the given start_index, the function was returning None, which doesn't match the expected return type of int.
I’ve fixed this by adding return -1 in case no space is found.
This ensures the function always returns an integer value as expected.

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this! Your change doesn't really make the error any better though, the exception will still be confusing. I've pushed an additional commit which improves this.

@jtraglia jtraglia merged commit 2ec9138 into ethereum:main Feb 27, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants