Skip to content

Commit

Permalink
core/types: remove json comments in *Tx objects
Browse files Browse the repository at this point in the history
These objects are not used with JSON directly, so it's confusing to have the
comments.
  • Loading branch information
fjl committed Jan 3, 2025
1 parent b37c9dc commit b2d69de
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions core/types/tx_blob.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ type BlobTx struct {
Sidecar *BlobTxSidecar `rlp:"-"`

// Signature values
V *uint256.Int `json:"v" gencodec:"required"`
R *uint256.Int `json:"r" gencodec:"required"`
S *uint256.Int `json:"s" gencodec:"required"`
V *uint256.Int
R *uint256.Int
S *uint256.Int
}

// BlobTxSidecar contains the blobs of a blob transaction.
Expand Down
6 changes: 3 additions & 3 deletions core/types/tx_dynamic_fee.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ type DynamicFeeTx struct {
AccessList AccessList

// Signature values
V *big.Int `json:"v" gencodec:"required"`
R *big.Int `json:"r" gencodec:"required"`
S *big.Int `json:"s" gencodec:"required"`
V *big.Int
R *big.Int
S *big.Int
}

// copy creates a deep copy of the transaction data and initializes all fields.
Expand Down
6 changes: 3 additions & 3 deletions core/types/tx_setcode.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ type SetCodeTx struct {
AuthList []SetCodeAuthorization

// Signature values
V *uint256.Int `json:"v" gencodec:"required"`
R *uint256.Int `json:"r" gencodec:"required"`
S *uint256.Int `json:"s" gencodec:"required"`
V *uint256.Int
R *uint256.Int
S *uint256.Int
}

//go:generate go run github.com/fjl/gencodec -type SetCodeAuthorization -field-override authorizationMarshaling -out gen_authorization.go
Expand Down

0 comments on commit b2d69de

Please sign in to comment.