Makefile: go build instead of install (solves cross compile issues)

[karalabe]

Go doesn't like the GOBIN env var being set simultaneously with cross-go install-ing. This PR works around that issue by using go build -i instead.

[robotally]

Vote	Count	Reviewers
👍	1	@caktux
👎	0

Updated: Sun May 8 14:36:10 UTC 2016

[caktux]

👍

[fjl]

I don't like this change because it disables incremental builds for everyone. That feels like too high a price to pay for a small workaround.

Wouldn't it work to

• not set GOBIN in build/env.sh
• add cp build/_workspace/bin/* build/bin as a step in the Makefile

[karalabe]

Why would it disable incremental builds? Note: go build -i. Emphasis on
the -i.

On May 6, 2016 23:24, "Felix Lange" [email protected] wrote:

I don't like this change because it disables incremental builds for
everyone. That feels like too high a price to pay for a small workaround.

Wouldn't it work to

• not set GOBIN in build/env.sh
• add cp build/_workspace/bin/* build/bin as a step in the Makefile

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#2520 (comment)

[fjl]

Ugh, didn't see the -i. Sorry.

[fjl]

I have tried it now and the disadvantage is that all commands need to be re-linked individually even if there are no source changes.

[karalabe]

Yup, though I think that's a smaller price to pay for now. Since this is blocking the release, I'd suggest we get this in now and perhaps fix it another way when we figure one out. I'm open to suggestion though if you don't like it.

[fjl]

Yes, it's ok to get this onto master.

[karalabe]

@fjl So, thumbs up? Mergable? :D

[karalabe]

@caktux Btw, thanks a lot for the quick fixes to the build servers!