eth: fixed regression in eth_signTransaction fixes #2578 #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign transaction returned the unsigned transaction rather than the signed one.
Updated: Thu May 19 10:02:45 UTC 2016 |
|
Why do we return the signed transaction in both RPL and JSON format? |
Current coverage is 55.90%@@ develop #2582 diff @@
==========================================
Files 215 215
Lines 24238 24238
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 13567 13549 -18
- Misses 10670 10689 +19
+ Partials 1 0 -1
|
|
@karalabe that's the implementation. It return the signed tx. The JSON can be used for verification. |
|
LGTM 👍 |
|
:+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sign transaction returned the unsigned transaction rather than the
signed one.
@bas-vk @karalabe PTAL