Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: remove EventMux accessors #30017

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

darioush
Copy link
Contributor

@darioush darioush commented Jun 17, 2024

Hi, it seems these methods in the backend.go and api_backend.go files are not used that expose the eventMux, but that is not needed.

@karalabe
Copy link
Member

I think that event mux was something we wanted dot get rid of altogether from everywhere. Any particular place that still references which we could rework to nuke out further?

@darioush
Copy link
Contributor Author

darioush commented Jun 18, 2024

It is used in eth/downloader to signal the start of the sync to the downloader API, and in cmd/geth/main.go to signal the end of the sync in case ExitWhenSyncedFlag is set. (see DoneEvent)

@fjl
Copy link
Contributor

fjl commented Jun 20, 2024

We could convert these events to be sent using event.FeedOf. That wasn't really possible earlier because we had the miner->downloader cross dependency, but should be doable now.

@fjl fjl marked this pull request as ready for review February 27, 2025 11:29
@fjl fjl changed the title eth: (backend, api_backend) remove unused methods eth: remove EventMux accessors Feb 27, 2025
@fjl fjl added this to the 1.15.4 milestone Feb 27, 2025
@rjl493456442 rjl493456442 merged commit 4038c59 into ethereum:master Feb 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants