Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signer/core, signer/core/apitypes: fix encoding of bytes nested within array #31049

Merged

Conversation

jwasinger
Copy link
Contributor

@jwasinger jwasinger commented Jan 20, 2025

closes #30979

@jwasinger jwasinger requested a review from holiman as a code owner January 20, 2025 09:29
@jwasinger jwasinger force-pushed the fix-signer-bytes-encoding branch from eed7850 to a38f103 Compare January 21, 2025 08:38
@MariusVanDerWijden MariusVanDerWijden self-assigned this Feb 6, 2025
@pythonberg1997
Copy link

When could this PR be merged?

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MariusVanDerWijden
Copy link
Member

looks like the lint failed

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MariusVanDerWijden MariusVanDerWijden merged commit 5552ada into ethereum:master Feb 21, 2025
4 checks passed
@s1na s1na added this to the 1.15.3 milestone Feb 21, 2025
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Mar 5, 2025
)

Fixes an incorrect encoding of recursive bytes types.
closes ethereum#30979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect recursive encoding of nested bytes arrays (bytes[]) in apitypes
4 participants