-
Notifications
You must be signed in to change notification settings - Fork 20.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signer/core, signer/core/apitypes: fix encoding of bytes
nested within array
#31049
Merged
MariusVanDerWijden
merged 6 commits into
ethereum:master
from
jwasinger:fix-signer-bytes-encoding
Feb 21, 2025
Merged
signer/core, signer/core/apitypes: fix encoding of bytes
nested within array
#31049
MariusVanDerWijden
merged 6 commits into
ethereum:master
from
jwasinger:fix-signer-bytes-encoding
Feb 21, 2025
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
commented
Jan 20, 2025
jwasinger
commented
Jan 20, 2025
jwasinger
commented
Jan 20, 2025
eed7850
to
a38f103
Compare
When could this PR be merged? |
MariusVanDerWijden
previously approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
looks like the lint failed |
MariusVanDerWijden
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Mar 5, 2025
) Fixes an incorrect encoding of recursive bytes types. closes ethereum#30979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30979