core/vm: clean up EVM environmental structure #31061
Conversation
rjl493456442
assigned rjl493456442, MariusVanDerWijden and s1na and unassigned rjl493456442
|
I will setup a full sync to ensure nothing is broken. As the changes touch very core part. |
| c.Code = code | ||
| c.CodeHash = hash | ||
| c.CodeAddr = addr |
There was a problem hiding this comment.
This was never used, right? weird...
There was a problem hiding this comment.
I don't know... At least it's not used now
rjl493456442
force-pushed
the
evm-remove-accountref
branch
from
27d3025 to
5893f07
Compare
There was a problem hiding this comment.
LGTM
For everyone else reviewing this, we slightly change the behavior with this.
Previously a contract created by CREATE2 would cache the jumpdest analysis for the initcode, while a contracted created by CREATE would not. Now both contracts will NOT cache the jumpdest analysis for initcode. Since it is very unlikely for two initcodes to be exactly the same, and in the case of an attack its very easy to circumvent this, its better not to bloat the memory with unusable jumpdest analyses
rjl493456442
force-pushed
the
evm-remove-accountref
branch
from
5893f07 to
4564ca0
Compare
rjl493456442
force-pushed
the
evm-remove-accountref
branch
from
4564ca0 to
e71bbae
Compare
|
|
||
| // CallContext provides a basic interface for the EVM calling conventions. The EVM | ||
| // depends on this context being implemented for doing subcalls and initialising new EVM contracts. | ||
| type CallContext interface { |
There was a problem hiding this comment.
Searching for vm.CallContext across github yields only https://github.com/Fantom-foundation/go-ethereum-substate/blob/ab1d0339012b5f67dae1c8bcff7ff1429feeff36/core/vm/evm.go#L133 which looks like an old version of the source. Probably safe to remove.
| paddedCodeCopy, copyOffset, nonPaddedCopyLength := getDataAndAdjustedBounds(code, uint64CodeOffset, length.Uint64()) | ||
| if !contract.IsSystemCall { |
There was a problem hiding this comment.
Looks like an alternative to #31114. Checking the conversation there it seems unresolved. Should we leave it out of this PR or do you think this is the correct fix for the issue?
| c.jumpdests = parent.jumpdests | ||
| } else { | ||
| c.jumpdests = make(map[common.Hash]bitvec) | ||
| func NewContract(caller common.Address, address common.Address, value *uint256.Int, gas uint64, jumpDests map[common.Hash]bitvec) *Contract { |
There was a problem hiding this comment.
What do you think about adding code and codeHash here? It seems in all cases we are doing:
c := NewContract()
c.SetCallCode
This PR does a few things including:
ContractRefinterfacevm.AccountRefwhich implementsContractRefinterfacejumpDestsstruct in EVM for sharing between call frames