params: add deposit contract addresses #31247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
fjl,
holiman,
karalabe,
gballet,
rjl493456442 and
zsfelfoldi
as code owners
params/config.go
Outdated
| @@ -117,6 +118,7 @@ var ( | |||
| ShanghaiTime: newUint64(1677557088), | |||
| CancunTime: newUint64(1706655072), | |||
| PragueTime: newUint64(1741159776), | |||
| DepositContractAddress: common.HexToAddress("0x4242424242424242424242424242424242424242"), | |||
There was a problem hiding this comment.
Suggested change
| DepositContractAddress: common.HexToAddress("0x4242424242424242424242424242424242424242"), | |
| DepositContractAddress: common.HexToAddress("0x7f02c3e3c98b133055b8b348b2ac625669ed295d"), |
See: https://sepolia.etherscan.io/tx/0x025ecbf81a2f1220da6285d1701dc89fb5a956b62562ee922e1a9efd73eb4b14
lightclient
reviewed
Feb 24, 2025
|
Are you going to push a release with this hot fix or should I simply cherry-pick the commit for now? |
|
Cherry-pick the commit. We will do a hotfix tomorrow, already past bedtime for EU |
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Feb 25, 2025
We forgot to add the deposit contract address for holesky, causing deposits to not be flagged correctly --------- Co-authored-by: lightclient <[email protected]>
|
Hi, thanks for fixing this. May I ask how to properly restart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to add the deposit contract address for holesky, causing deposits to not be flagged correctly