core/txpool: fix error logs flood caused by removeAuthorities #31249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
force-pushed
the
only_removeAuthorities_SetCodeTxType
branch
from
8692589 to
77b28a0
Compare
buddh0
changed the title
|
@lightclient has also created his own PR to fix this: #31263 |
lightclient
force-pushed
the
only_removeAuthorities_SetCodeTxType
branch
from
ad1d4e3 to
1212781
Compare
lightclient
approved these changes
Feb 26, 2025
|
Thanks @buddh0. I made a few small adjustments and added some additional testing. |
rjl493456442
approved these changes
Feb 27, 2025
NathanBSC
approved these changes
Feb 27, 2025
LGTM,thx |
tnasu
added a commit
to tnasu/kaia
that referenced
this pull request
Mar 5, 2025
tnasu
added a commit
to tnasu/kaia
that referenced
this pull request
Mar 5, 2025
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Mar 5, 2025
…um#31249) when remove an non-SetCodeTxType transaction, error logs flood ``` t=2025-02-25T03:11:06+0000 lvl=error msg="Authority with untracked tx" addr=0xD5bf9221fCB1C31Cd1EE477a60c148d40dD63DC1 hash=0x626fdf205a5b1619deb2f9e51fed567353f80acbd522265b455daa0821c571d9 ``` in this PR, only try to removeAuthorities for txs with SetCodeTxType in addition, the performance of removeAuthorities improved a lot, because no need range all `t.auths` now. --------- Co-authored-by: lightclient <[email protected]>
sonhv0212
added a commit
to sonhv0212/ronin
that referenced
this pull request
Mar 11, 2025
sonhv0212
added a commit
to sonhv0212/ronin
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when remove an non-SetCodeTxType transaction, error logs flood
in this PR, only try to removeAuthorities for txs with SetCodeTxType
in addition, the performance of removeAuthorities improved a lot,
because no need range all
t.authsnow.