Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: filter out .git folder for generation check #31265

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

rjl493456442
Copy link
Member

Fix the lint error

go run build/ci.go check_generate
build/cache/protoc-27.1-linux-x86_64.zip is stale
downloading from https://github.com/protocolbuffers/protobuf/releases/download/v27.1/protoc-27.1-linux-x86_64.zip
10%...20%...30%...40%...50%...60%...70%...80%...90%...100%
build/cache/protoc-gen-go.v1.34.2.linux.amd64.tar.gz is stale
downloading from https://github.com/protocolbuffers/protobuf-go/releases/download/v1.34.2/protoc-gen-go.v1.34.2.linux.amd64.tar.gz
10%...20%...30%...40%...50%...60%...70%...80%...90%...100%
>>> /home/appveyor/.gvm/gos/go1.24.0/bin/go generate ./...
ci.go:404: File changed: .git/index
ci.go:407: One or more generated files were updated by running 'go generate ./...'
exit status 1
Command exited with code 1

@rjl493456442 rjl493456442 added this to the 1.15.4 milestone Feb 26, 2025
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@jwasinger
Copy link
Contributor

Why would running go generate change .git/index? I thought this only contains manually staged changes.

@rjl493456442
Copy link
Member Author

rjl493456442 commented Feb 26, 2025

I think the default target is all folders, ./...

I don't understand why .git/index will be generated, to be honest.

But .git should be safe to excluded right? It's definitely not our generation target

@fjl fjl merged commit c7caca4 into ethereum:master Feb 26, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants