Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yul: Remove boolType and defaultType from dialect #15332

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

clonker
Copy link
Member

@clonker clonker commented Aug 14, 2024

No description provided.

@clonker clonker force-pushed the remove_yul_dialect_types branch from eafd149 to b6c34dc Compare August 14, 2024 08:37
@clonker clonker requested a review from aarlt August 14, 2024 08:47
aarlt
aarlt previously approved these changes Aug 14, 2024
@clonker clonker force-pushed the remove_yul_dialect_types branch from 66004ee to a0e8b02 Compare August 15, 2024 08:22
@ethereum ethereum deleted a comment from stackenbotten Aug 15, 2024
@ethereum ethereum deleted a comment from stackenbotten Aug 15, 2024
@clonker clonker force-pushed the remove_yul_dialect_types branch 2 times, most recently from 7c40424 to 6b6972e Compare August 15, 2024 08:28
@clonker clonker force-pushed the remove_yul_dialect_types branch from 6b6972e to c2ae2e2 Compare August 15, 2024 09:36
aarlt
aarlt previously approved these changes Aug 15, 2024
Copy link
Member

@aarlt aarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just left some general questions about other related things.

@clonker clonker force-pushed the remove_yul_dialect_types branch 3 times, most recently from d62ce08 to 1890a67 Compare August 20, 2024 09:30
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only needs a few small tweaks and it will be ready to go.

@clonker clonker force-pushed the remove_yul_dialect_types branch 2 times, most recently from d73a5bf to ec2536e Compare August 27, 2024 08:43
cameel
cameel previously approved these changes Aug 27, 2024
@clonker clonker force-pushed the remove_yul_dialect_types branch from 03b01c1 to 4938075 Compare August 28, 2024 10:07
@clonker clonker merged commit 664ee23 into develop Aug 28, 2024
72 checks passed
@clonker clonker deleted the remove_yul_dialect_types branch August 28, 2024 11:25
ibrahimkhled

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants