Do not cache instances of Compiler in CompilerStack
#15460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
added
performance 🐎
has dependencies
BenchmarksResults from
Looks like it does not make much difference, both in terms of memory and execution time. |
|
I added a commit that removes the With this results seem on par with #15459 (comment). Benchmarks after
|
| File | Time (before) | Time (after) | Memory (before) | Memory (after) |
|---|---|---|---|---|
| openzeppelin | 9 s | 11 s | 517 MiB | 454 MiB |
| uniswap-v4 | 20 s | 20 s | 1012 MiB | 902 MiB |
| eigenlayer | 72 s | 76 s | 2833 MiB | 2411 MiB |
| seaport | 150 s | 150 s | 4477 MiB | 3896 MiB |
| sablier-v2 | 141 s | 141 s | 5215 MiB | 5020 MiB |
IR
| File | Time (before) | Time (after) | Memory (before) | Memory (after) |
|---|---|---|---|---|
| openzeppelin | 31 s | 35 s | 497 MiB | 496 MiB |
| uniswap-v4 | 117 s | 127 s | 1491 MiB | 1498 MiB |
| eigenlayer | 509 s | 515 s | 4455 MiB | 4461 MiB |
The running time here seemingly increased, but I suspect it's just a fluke. Will rerun to make sure. EDIT: Yeah, just a fluke.
Base automatically changed from
compiler-stack-do-not-store-serialized-json
to
develop
September 27, 2024 13:17
cameel
removed
the
has dependencies
cameel
force-pushed
the
compiler-stack-do-not-store-compiler-instances
branch
from
aebd331 to
44a6f8f
Compare
clonker
approved these changes
Sep 30, 2024
cameel
force-pushed
the
compiler-stack-do-not-store-compiler-instances
branch
from
44a6f8f to
3c5e46b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #15451.Merged.Related to #15459.
Another follow-up to #15451, this time removing the
Compilerinstances stored inCompilerStack.This is a test PR to benchmark it see if it's even worth it. But TBH storing these objects in CompilerStack seems like a weird design choice. Apparently the only thing we need from them are the generated sources. And it's not even like they're generated on demand - they're stored in compiler context and simply copied from there. For this reason I'd be in favor of merging this even it does not improve performance. Just not making it worse would be enough.