-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grammar & Clarity Fixes (Reopened) #15885
base: develop
Are you sure you want to change the base?
Conversation
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
Now if you could please squash your commits :) |
Done |
Well no, now you have added a merge commit again instead of squashing :P
Thanks! |
Also, if you're planning to do more fixes of this kind, please include them already in this PR rather than opening new ones (you can keep this one open and add new things until you're done). We're happy to accept even trivial fixes, but we're flooded with tons of such PRs and it would be nice to keep their number reasonable. |
Okay, I'll keep that in mind. |
File: test/externalTests/brink_test.sh
Before: "Remove this when Brink merges"
After: "Remove once Brink merges PR #52"
Fixed grammar in flaky test comment
File: test/externalTests/elementfi_test.sh
Before: "one particular cases" → "one particular case"
Before: "depends" → "depend"