Get rid of assertThrow() in soltest
#15906
Merged
+33
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
approved these changes
Mar 3, 2025
cameel
force-pushed
the
get-rid-of-assert-throw-in-tests
branch
from
f6aee19 to
7ffb394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny bit of cleanup extracted from #15905. I removed a couple of
assertThrow()s from the code I was touching and then noticed that there aren't that many left in tests overall so I can just do them all.For context,
assertThrow()is a weird legacy macro that is named as if it was an assert but instead of reporting an ICE, throws the user-supplied exception, which makes it a validation (when used properly). And of course it's often abused for things that are not validations. There's no reason to use it at all and it should eventually be replaced by the more self-explanatorysolAssert()/solRequire()/solUnimplemented(), depending on what it's actually used for.